Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

The # of elements for a collection are shown in the usage. #199

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Aug 27, 2016

Implements #158

Likely #188 should be merged before this one.

@codecov-io
Copy link

codecov-io commented Aug 27, 2016

Current coverage is 91.51% (diff: 90.00%)

Merging #199 into master will increase coverage by 0.03%

@@             master       #199   diff @@
==========================================
  Files            54         54          
  Lines          2173       2181     +8   
  Methods        2040       2052    +12   
  Messages          0          0          
  Branches        133        129     -4   
==========================================
+ Hits           1988       1996     +8   
  Misses          185        185          
  Partials          0          0          

Powered by Codecov. Last update 11de2b0...b3c5103

@tfenne
Copy link
Member

tfenne commented Aug 27, 2016

Looks really nice. The only suggestion I have is that collectionDescription and makeCollectionDescription make it sound like it would be the full description of the option - perhaps call them something like collectionArity or collectionArityString?

Merge when you're happy.

@tfenne tfenne assigned nh13 and unassigned tfenne Aug 27, 2016
@nh13 nh13 force-pushed the nh_collection_elements_printing branch from c03982f to b3c5103 Compare August 29, 2016 00:40
@nh13 nh13 merged commit f5489d7 into master Sep 1, 2016
@nh13 nh13 deleted the nh_collection_elements_printing branch September 1, 2016 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants