This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Do not merge: Expose a few command line options for scheduling strategies. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.42% (diff: 47.36%)
|
|
Bump. Given a few more multi-sample pipelines and whole genome pipelines, this may be more relevant. @tfenne thoughts? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfenne looking for some feedback. My only regret is having to use a Java enum to expose the strategy options on the command line. Perhaps I could play with
ClassFinderto find all classes that extendSelectTaskSchedulerinstead. Tests will be added and code cleaned up when the idea becomes more fully formed.