Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure RTD to checkout submodules #23

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Configure RTD to checkout submodules #23

merged 2 commits into from
Sep 11, 2023

Conversation

jdidion
Copy link
Collaborator

@jdidion jdidion commented Sep 11, 2023

Our RTD config was out of date. I made the following updates:

  • Change from build.image: latest to bulid.os: ubuntu-22.04
  • Add build.tools
  • Add submodules.include: all

Confirmed that the updates work: https://readthedocs.org/projects/pybedlite/builds/21890877/

In addition, I updated the docs to specify python 3.8 as the minimum supported version, and removed the note about not being able to publish to pypi.

…ion in docs; remove note about not being able to publish to conda
@jdidion jdidion marked this pull request as draft September 11, 2023 21:17
@jdidion jdidion changed the base branch from main to ver-bump-0.0.5 September 11, 2023 21:38
@jdidion jdidion requested a review from nh13 September 11, 2023 21:38
@jdidion jdidion marked this pull request as ready for review September 11, 2023 21:38
Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank-you!

@jdidion jdidion changed the base branch from ver-bump-0.0.5 to main September 11, 2023 22:07
@jdidion jdidion merged commit 7f51e67 into main Sep 11, 2023
4 checks passed
@jdidion jdidion deleted the ci-21-rtd-submodules branch September 13, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants