-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the release process to leverage GitHub Actions #37
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few Qs, and we'll need to set up a few things before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 8 8
Lines 674 674
Branches 119 119
=======================================
Hits 642 642
Misses 18 18
Partials 14 14 ☔ View full report in Codecov by Sentry. |
@nh13 I might need some help allowing GitHub to be a PyPi publisher. Although I have access to release new versions of Could you navigate to here and add a GitHub publisher with the following values?
|
Done, for |
Ah! My playground for ideas :) |
@@ -40,8 +40,7 @@ jobs: | |||
with: | |||
submodules: "true" | |||
|
|||
# Used to host cibuildwheel | |||
- uses: actions/setup-python@v4 | |||
- uses: actions/setup-python@v5 | |||
with: | |||
python-version: 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be ${{ matrix.python }}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you really do just need a single and separate Python for building the wheels. It's OK to use 3.8 here. I think I've tried bumping it up, but you'll hit compatibility issues with cibuidwheel
and a few of the other configuration in the GitHub action. At some point I'll get this up to 3.12 and fixup the rest too. You're welcome to try swapping 3.8 for 3.12 (or something else newer) here and chasing down any errors/warnings with cibuildwheel
.
Dependent on:
chore(release): bump to X.X.X
The publish workflow looks like: