Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix all vars with fullstory, add descriptions to README, general hygiene #10

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

huttotw
Copy link
Contributor

@huttotw huttotw commented Nov 16, 2023

A couple things here:

  1. Prefixing all of our vars with the standard fullstory_ will make sure that our vars will not collide with any other DBT package.
  2. When using this DBT package, I found it necessary to be able to provide the database, schema and table name explicitly so that we don't need to run the consuming DBT project in the same dataset as the raw events table. To support this, I introduced: fullstory_events_database, fullstory_events_schema and fullstory_events_table. This allows us to sync the events table once using Data Destinations, then use the same table across many projects or datasets (Big Query).
  3. Updated variable names to be more consistent / better indicate their purpose.

@craigrmccown this also addresses feedback here.

@huttotw huttotw requested a review from craigrmccown November 16, 2023 21:00
@huttotw huttotw changed the title prefix all vars with fullstory, add descriptions to README prefix all vars with fullstory, add descriptions to README, general hygiene Nov 17, 2023
@huttotw huttotw requested a review from sgagofs November 20, 2023 18:46
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link

@sgagofs sgagofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huttotw huttotw merged commit b5f665c into main Nov 21, 2023
1 check passed
@huttotw huttotw deleted the fix/prefix-all-vars branch November 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants