-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Golang 1.23 #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonsinth
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure why not
Seems like predeclared ./...
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5bd12f]
goroutine 10 [running]:
go/types.(*Checker).handleBailout(0xc001709340, 0xc000efbbf0)
/usr/local/go/src/go/types/check.go:404 +0x88
panic({0x726a40?, 0x9bcbd0?})
/usr/local/go/src/runtime/panic.go:785 +0x132
go/types.(*StdSizes).Sizeof(0x0, {0x7f4380, 0x9c0900})
/usr/local/go/src/go/types/sizes.go:229 +0x30f
go/types.(*Config).sizeof(...)
/usr/local/go/src/go/types/sizes.go:334
go/types.representableConst.func1({0x7f4380?, 0x9c0900?})
/usr/local/go/src/go/types/const.go:77 +0x86
go/types.representableConst({0x7f5b28, 0x9b5520}, 0xc001709340, 0x9c0900, 0xc0017ad6a8)
/usr/local/go/src/go/types/const.go:107 +0x2a7
go/types.(*Checker).conversion.func1({0x7f43d0?, 0xc0013b0d20?}, 0xc0017ad6a8)
/usr/local/go/src/go/types/conversions.go:27 +0x73
go/types.(*Checker).conversion(0xc001709340, 0xc0017ad680, {0x7f43d0, 0xc0013b0d20})
/usr/local/go/src/go/types/conversions.go:47 +0x246
go/types.(*Checker).callExpr(0xc001709340, 0xc0017ad680, 0xc000cfe540)
/usr/local/go/src/go/types/call.go:218 +0xbee
go/types.(*Checker).exprInternal(0xc001709340, 0x0, 0xc0017ad680, {0x7f5738, 0xc000cfe540}, {0x0, 0x0})
/usr/local/go/src/go/types/expr.go:1410 +0xf8
go/types.(*Checker).rawExpr(0xc001709340, 0x0, 0xc0017ad680, {0x7f5738?, 0xc000cfe540?}, {0x0?, 0x0?}, 0x0)
/usr/local/go/src/go/types/expr.go:981 +0x18c
go/types.(*Checker).expr(0xc001709340, 0x729020?, 0xc0017ad680, {0x7f5738?, 0xc000cfe540?})
/usr/local/go/src/go/types/expr.go:1549 +0x30
go/types.(*Checker).constDecl(0xc001709340, 0xc001554900, {0x0, 0x0}, {0x7f5738, 0xc000cfe540}, 0x0)
/usr/local/go/src/go/types/decl.go:480 +0x2c8
go/types.(*Checker).objDecl(0xc001709340, {0x7f8778, 0xc001554900}, 0x0)
/usr/local/go/src/go/types/decl.go:185 +0xa09
go/types.(*Checker).packageObjects(0xc001709340)
/usr/local/go/src/go/types/resolver.go:714 +0x454
go/types.(*Checker).checkFiles(0xc001709340, {0xc001452338, 0x1, 0x1})
/usr/local/go/src/go/types/check.go:459 +0x15a
go/types.(*Checker).Files(0xc00020c000?, {0xc001452338?, 0xc0015542a0?, 0x6?})
/usr/local/go/src/go/types/check.go:422 +0x75
golang.org/x/tools/go/packages.(*loader).loadPackage(0xc00020c000, 0xc000712840)
/home/circleci/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:1052 +0xa32
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1()
/home/circleci/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:851 +0x1a9
sync.(*Once).doSlow(0x0?, 0x0?)
/usr/local/go/src/sync/once.go:76 +0xb4
sync.(*Once).Do(...)
/usr/local/go/src/sync/once.go:67
golang.org/x/tools/go/packages.(*loader).loadRecursive(0x0?, 0x0?)
/home/circleci/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:839 +0x3b
golang.org/x/tools/go/packages.(*loader).refine.func2(0x0?)
/home/circleci/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:774 +0x26
created by golang.org/x/tools/go/packages.(*loader).refine in goroutine 1
/home/circleci/go/pkg/mod/golang.org/x/[email protected]/go/packages/packages.go:773 +0xcaf
|
Signed-off-by: Or Shachar <[email protected]>
@dragonsinth - ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #422