Skip to content

Conversation

Zerim
Copy link
Collaborator

@Zerim Zerim commented Dec 20, 2017

This PR introduces two changes:

  • Tells webpack not to resolve symlinks to their actual location (this allows loaders, specifically ts-loader to find the file correctly).
  • Adds a "rootNodeModules" path to the include path of ts-loader.

The rootNodeModules represents the path of where the node_modules might be in a yarn workspace monorepo. As of this change, what yarn does is hoist and symlink dependencies in the node_modules of the root directory of the monorepo. These two changes allow ts-loader to correctly find and load those dependencies.

@Jannis
Copy link

Jannis commented Dec 20, 2017

I don't think I can perform a useful review at this point, as I don't understand the problem. ;)

If it works, then I'm good with the changes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants