This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Doomsday - FooterSocials #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use the color vars specified in the issue description. |
|
i saw that, but they are the same as they other colors, seems redundant. unless you plan on changing them later |
|
Yes they will be changed on the page routes they need to be changed on. This way all the colors are controlled in one place, the CSS. |
|
OK i like that, then there's no need for the color prop. I'll make that change and add a |
|
I fixed the hover issue as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components included in this PR are:
Notes
Got exact font details from Dave.
I added a prop for
color-themeto make things easier. Seems there are at least 3 colors: pink, black, and orange.When this component is added to the project, you should delete
.mock-nuxt-linkclass in scss. When using real WpMenuItems from WPGQL it will be an external link and use an anchor tag.The hover-off effect feels off to me. I want to add a delay to
webkit-text-strokeon hover off, but can't seem to target it. I tried usingwebkit-text-stroke-widthand-webkit-text-stroke-colorspecifically but still couldn't make it work even though the spec says you should be able to apply transitions to-webkit-text-stroke-color.