fix background functionality

funktechno · Jun 21, 2019 · afd9035 · afd9035
1 parent 5aaf73d
commit afd9035
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 11 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,9 @@
+## 0.0.3
+
+### fixes
+* fix github render bug
+* remove many uneeded permissions
+
 ## 0.0.2
 
 ### fixes

diff --git a/core/webpack.base.js b/core/webpack.base.js
@@ -96,7 +96,6 @@ module.exports = {
     // htmlPage('devtools', 'devtools', ['devtools']),
     // htmlPage('options', 'options', ['options']),
     htmlPage('background', 'background', ['background']),  
-
     new CopyWebpackPlugin([{ from: path.join(__dirname, '..', 'static') }]),
     new ChromeReloadPlugin({
       port: 9090,

diff --git a/src/backend/index.js b/src/backend/index.js
@@ -10,8 +10,26 @@ let backEnd = function () {
   chrome.webNavigation.onHistoryStateUpdated.addListener(function (details) {
     chrome.tabs.query({ 'active': true, 'lastFocusedWindow': true }, function (tabs) {
       var url = tabs[0].url
-      if (url.indexOf("github.com") !== -1 || url.indexOf("bitbucket.org") !== -1) {
-        chrome.tabs.executeScript(null, { file: "js/inject.js" })
+      if (url && (url.indexOf("github.com") !== -1 || url.indexOf("bitbucket.org") !== -1)) {
+        // must inject manifest and vendor before running inject
+        chrome.tabs.executeScript(null, {
+          file: 'js/manifest.js',
+          runAt: 'document_end'},
+        function (result) {
+          console.log("done loading file manifest" + JSON.stringify(result))
+        })
+        chrome.tabs.executeScript(null, {
+          file: 'js/vendor.js',
+          runAt: 'document_end'},
+        function (result) {
+          console.log("done loading file vendor" + JSON.stringify(result))
+        })
+        chrome.tabs.executeScript(null, {
+          file: 'js/inject.js',
+          runAt: 'document_end'},
+        function (result) {
+          console.log("done loading file inject:" + JSON.stringify(result))
+        })
       }
     })
     // if(chrome.runtime.lastError) {

diff --git a/src/manifest-custom.js b/src/manifest-custom.js
@@ -1,16 +1,14 @@
 
 module.exports = {
   name: 'Git Kanban Enhanced Self Hosted',
-  version: '0.0.2',
+  version: '0.0.3',
   description: 'Kanban extensions for self hosted github, gitlab, bitbucket, and gitea',
   author: "http://github.com/lastlink",
   manifest_version: 2,
   icons: { '16': 'icons/16.png', '128': 'icons/128.png' },
   homepage_url: "https://github.com/funktechno/git-kanban-enhanced-chrome-extension",
   permissions: [
     '<all_urls>',
-    '*://*/*',
-    'tabs',
     'background',
     'contextMenus',
     'storage',
@@ -23,20 +21,26 @@ module.exports = {
   background: {
     persistent: true,
     "scripts": [
+      'js/manifest.js',
+      'js/vendor.js',
       "js/background.js"
     ]
   },
   // devtools_page: 'pages/devtools.html',
   // options_page: 'pages/options.html',
   content_scripts: [{
-    js: [ 'js/inject.js' ],
+    js: [
+      'js/manifest.js',
+      'js/vendor.js',
+      'js/inject.js'
+    ],
     "exclude_matches": [
       "*://extensions/*"
     ],
     run_at: 'document_end',
     matches: ['<all_urls>'],
     all_frames: true
   }],
-  content_security_policy: "script-src 'self' 'unsafe-eval'; object-src 'self'",
+  content_security_policy: "script-src 'self' 'unsafe-eval'; object-src 'self'"
   // web_accessible_resources: [ 'js/content.js' ]
 }
diff --git a/src/manifest-main.js b/src/manifest-main.js
@@ -1,7 +1,7 @@
 
 module.exports = {
   name: 'Git Kanban Enhance',
-  version: '0.0.2',
+  version: '0.0.3',
   description: 'Kanban extensions for github, gitlab, gitea, and bitbucket',
   author: "http://github.com/lastlink",
   manifest_version: 2,
@@ -12,7 +12,6 @@ module.exports = {
     "*://bitbucket.org/*",
     "*://gitlab.com/*",
     "*://gitea.com/*",
-    'tabs',
     'background',
     'contextMenus',
     'storage',
@@ -25,13 +24,19 @@ module.exports = {
   background: {
     persistent: true,
     "scripts": [
+      'js/manifest.js',
+      'js/vendor.js',
       "js/background.js"
     ]
   },
   // devtools_page: 'pages/devtools.html',
   // options_page: 'pages/options.html',
   content_scripts: [{
-    js: [ 'js/inject.js' ],
+    js: [
+      'js/manifest.js',
+      'js/vendor.js',
+      'js/inject.js'
+    ],
     "exclude_matches": [
       "*://extensions/*"
     ],