Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle function deletion in workers #215

Merged
merged 11 commits into from
Feb 25, 2024
Merged

Conversation

mattrent
Copy link
Member

This PR adds the correct handling of the delete message for functions. Specifically, now the core sends a delete message to all workers when a function is removed, ensuring that the old code is not running on the platform after deletion.

Additionally:

  • adds a new hash field to functions. This is calculated from the function's code, and identifies each invoke/update/delete command to ensure the correct version of the function is being targeted on workers;
  • pushes the new code to workers when issuing an update command;
  • extends the cleanup method on workers to target RawResourceStorage as well
  • fixes a bug in the release of both core and worker, where node_ip was being ignored

This closes #70.

@mattrent mattrent requested a review from giusdp as a code owner February 23, 2024 15:47
@mattrent mattrent self-assigned this Feb 23, 2024
@mattrent mattrent merged commit 9d8d0f4 into funlessdev:main Feb 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete function runtimes when a function is deleted from the database
2 participants