Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] week 1 blog GSoC #892

Merged
merged 3 commits into from
Jun 13, 2024
Merged

[DOC] week 1 blog GSoC #892

merged 3 commits into from
Jun 13, 2024

Conversation

robinroy03
Copy link
Member

Week 1 GSoC Blog.

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (4baa99d) to head (14377fd).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files          44       44           
  Lines       10553    10553           
  Branches     1432     1432           
=======================================
  Hits         8904     8904           
  Misses       1270     1270           
  Partials      379      379

@WassCodeur WassCodeur self-requested a review June 6, 2024 16:56
skoudoro
skoudoro reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice blogpost @robinroy03,

See below some comments

docs/source/posts/2024/2024-06-06-week-1-robin.rst Show resolved Hide resolved
docs/source/posts/2024/2024-06-06-week-1-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-06-06-week-1-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-06-06-week-1-robin.rst Outdated

.. raw:: html

<iframe src="https://drive.google.com/file/d/1k8nVQ_7-Jl_1P78PGuhjUxu5rJEc8TZn/preview" width="640" height="390" frameborder="0" allowfullscreen></iframe>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use a drive link. Please, upload the figure in https://github.com/fury-gl/fury-communication-assets
and then use the link from github.

Another alternative is to host the figure here: https://github.com/fury-gl/fury/tree/master/docs/source/_static/images

Copy link
Member Author

@robinroy03 robinroy03 Jun 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skoudoro, I was unable to embed the video (webm), therefore I embedded the video like this https://github.com/robinroy03/fury-discord-bot/assets/115863770/48f1136d-18a5-45ee-aa22-0a3f6426d575, GitHub generates this when we add videos directly to a file.

I did not find other methods.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real link seems to be https://github-production-user-asset-6210df.s3.amazonaws.com/115863770/337997458-48f1136d-18a5-45ee-aa22-0a3f6426d575.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA/20240610/us-east-1/s3/aws4_request&X-Amz-Date=20240610T083259Z&X-Amz-Expires=300&X-Amz-Signature=16c7c80270d05413508fd4b980002e0374222eab82669551c184f51a80cb1500&X-Amz-SignedHeaders=host&actor_id=23106443&key_id=0&repo_id=805183067

docs/source/posts/2024/2024-06-06-week-1-robin.rst Show resolved Hide resolved
itellaetxe
itellaetxe approved these changes Jun 7, 2024
View reviewed changes
Copy link

@itellaetxe itellaetxe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work is very interesting Robin, good week!
Find some small improvement comments below. Comments aside, I approve this PR.

docs/source/posts/2024/2024-06-06-week-1-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-06-06-week-1-robin.rst Outdated Show resolved Hide resolved
@robinroy03 robinroy03 mentioned this pull request Jun 7, 2024
Merged
@robinroy03 robinroy03 requested a review from skoudoro June 9, 2024 18:29
@skoudoro
Copy link
Contributor

skoudoro commented Jun 10, 2024 •
edited
Loading

waiting for @deka27 review to move forward

@deka27
Copy link
Contributor

deka27 commented Jun 10, 2024

I will approve for now. But I believe the video part can be fixed via the statics folder. Also, sorry for delayed review.

@robinroy03
Copy link
Member Author

@skoudoro PTAL

skoudoro
skoudoro approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you @robinroy03 , merging

@skoudoro skoudoro merged commit 32799d2 into fury-gl:master Jun 13, 2024
29 of 31 checks passed
WassCodeur pushed a commit to WassCodeur/fury that referenced this pull request Jul 10, 2024
@robinroy03 @WassCodeur
[DOC] week 1 blog GSoC (fury-gl#892)
70594dc 
* [GSoC] week 1 - robin
WassCodeur pushed a commit to WassCodeur/fury that referenced this pull request Jul 10, 2024
@robinroy03 @WassCodeur
[DOC] week 1 blog GSoC (fury-gl#892)
439c86f 
* [GSoC] week 1 - robin
WassCodeur pushed a commit to WassCodeur/fury that referenced this pull request Jul 10, 2024
@robinroy03 @WassCodeur
[DOC] week 1 blog GSoC (fury-gl#892)
01ed38a 
* [GSoC] week 1 - robin
WassCodeur pushed a commit to WassCodeur/fury that referenced this pull request Jul 10, 2024
@robinroy03 @WassCodeur
[DOC] week 1 blog GSoC (fury-gl#892)
ee49617 
* [GSoC] week 1 - robin
WassCodeur pushed a commit to WassCodeur/fury that referenced this pull request Jul 13, 2024
@robinroy03 @WassCodeur
[DOC] week 1 blog GSoC (fury-gl#892)
ef794cb 
* [GSoC] week 1 - robin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoudoro skoudoro skoudoro approved these changes

@itellaetxe itellaetxe itellaetxe approved these changes

@WassCodeur WassCodeur WassCodeur approved these changes

@deka27 deka27 deka27 approved these changes

@m-agour m-agour Awaiting requested review from m-agour

Assignees
No one assigned
Labels
type:Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robinroy03 @skoudoro @deka27 @itellaetxe @WassCodeur