Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update token #7

Open
wants to merge 2 commits into
base: upgradable2
Choose a base branch
from
Open

Update token #7

wants to merge 2 commits into from

Conversation

MayankMittal1
Copy link
Collaborator

No description provided.

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 21, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

leonprou
leonprou reviewed May 9, 2024
View reviewed changes
contracts/WrappedTokenBridgeUpgradable.sol

localToRemote[localToken][remoteChainId] = remoteToken;
remoteToLocal[remoteToken][remoteChainId] = localToken;
emit RegisterToken(localToken, remoteChainId, remoteToken);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How those events are used?
do we need UneegisterToken event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonprou leonprou leonprou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MayankMittal1 @leonprou