[WIP] - Added assignment of nodes via the quickstart script #81
Conversation
There was a problem hiding this comment.
Sorry to be late in this. Couple of comments
- Does the validator had to be admin in the group? If yes we're missing the validators that launch without talking with us at all. And that's the biggest problem I think :).
- Don't like too much addfing more dependencies from security perspective. Referring to TG-cli mainly.
Can we instead build an API endpoint on the bot, that will add the validators? by using the telegram-cli for example. I think doing this will sort out both issues I mention. @Andrew-Pohl what you think?
Hey @leonprou Yes they have to be admin in the validator group. This is to stop random people from assigning nodes to themselves which don't belong to them. I can certainly add an endpoint to do this but it's just what I mentioned above which will still be an issue in fact maybe worse (can just spam the endpoint for example) |
|
I think maybe we could edit the consensus contract and store the names/ details on chain and the bot grabs these from the consensus. more scalable (and don't need to change anything on the staking app side what do you think?) |
|
@Andrew-Pohl I'm very conservative about changing the consensus contracts. I think only the core logic should be there, rest of the functionality will be build on top of this. We can do a brainstorming on this |
Gotcha, yes we can put this anywhere really. A new "Validator info" contract or something |
No description provided.