Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto update support for containers #93

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Andrew-Pohl
Copy link
Member

No description provided.

@Andrew-Pohl Andrew-Pohl changed the title [WIP] - add auto update support for containers Add auto update support for containers Feb 8, 2021
@Andrew-Pohl Andrew-Pohl requested a review from leonprou February 8, 2021 10:42
@Andrew-Pohl
Copy link
Member Author

Andrew-Pohl commented Feb 8, 2021

@leonprou good to go now are you able to do your magic and make checkForUpdates.sh executable by default? (not sure how you did that last time)

Copy link

@ArseniiPetrovich ArseniiPetrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is good, but I have some concern about it's stability. Some of them are minor and some are not. Please, check my comments below.

scripts/checkForUpdates.sh Outdated Show resolved Hide resolved
scripts/checkForUpdates.sh Outdated Show resolved Hide resolved
scripts/checkForUpdates.sh Outdated Show resolved Hide resolved
scripts/checkForUpdates.sh Show resolved Hide resolved
@Andrew-Pohl
Copy link
Member Author

@ArseniiPetrovich thanks for the comments will push some changes tonight :)

@Andrew-Pohl
Copy link
Member Author

Ok made @ArseniiPetrovich suggested changes also rebased onto master and fixed some conflicts

Copy link

@ArseniiPetrovich ArseniiPetrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now it looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants