-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved energy distribution using NeSST #89
Conversation
…gy/openmc-plasma-source into improved_energy_distribution
…gy/openmc-plasma-source into improved_energy_distribution
…gy/openmc-plasma-source into improved_energy_distribution
…gy/openmc-plasma-source into improved_energy_distribution
…gy/openmc-plasma-source into improved_energy_distribution
…gy/openmc-plasma-source into improved_energy_distribution
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 95.96% 95.74% -0.23%
==========================================
Files 7 5 -2
Lines 347 235 -112
==========================================
- Hits 333 225 -108
+ Misses 14 10 -4 ☔ View full report in Codecov by Sentry. |
tests are passing locally and on CI only missing code coverage now |
This PR is currently reducing the package by a reasonable amount of lines of code while also adding functionality. I've redone the checking of values so that it is more concise as mentioned by @RemDelaporteMathurin I'm keen to see if this issue can be fixed before we bring in nesst as a dependency |
I just noticed another part of the code that will need changing to support DD and DT reactions. It looks like this part is only considering DT reactions
So we might need to add DD reactions Also I guess the ion_density for DD pairs is also half that of DT pairs @RemDelaporteMathurin do you remember why this is |
closing in favour of #95 |
This PR is an attempt to make use of NeSST to define the neutron spectra. Closes #88
I have a bit more work to do before it is ready, for example I'm going to see if I can combined the Muir spectra for DD and DT neutrons with the openmc.stats.Discrete distribution for the TT neutrons.
going to try combining with this