This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add @babel/plugin-transform-flow-strip-types in favor of @babel/preset-flow #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGrandon
force-pushed
the
add-class-props-test
branch
2 times, most recently
from
90b039f to
bcac52a
Compare
KevinGrandon
force-pushed
the
add-class-props-test
branch
from
bcac52a to
826c45a
Compare
KevinGrandon
changed the title
KevinGrandon
force-pushed
the
add-class-props-test
branch
from
826c45a to
98b2891
Compare
KevinGrandon
changed the title
lhorie
approved these changes
Sep 5, 2018
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/plugin-transform-flow-strip-types.Note: We were including
@babel/preset-flowinside of ourget-babel-config.jsfile, but it seems to not actually work. It seems that this is due to some other plugins running before the preset, possibly@babel/plugin-proposal-class-properties. We have to unshift the plugin to strip flow types first. This means that we can remove the@babel/preset-flowplugin.This bug was introduced from #486