-
Notifications
You must be signed in to change notification settings - Fork 21
Change createBrowserHistory imports #250
base: master
Are you sure you want to change the base?
Conversation
The method of importing createBrowserHistory with `import createBrowserHistory from 'history/createBrowserHistory'` causes warning messages during testing. The message produced below includes an example of how to import the `createBrowserHistory` function. This change updates the code to be compatible with the intent of the message. ``` console.error node_modules/history/warnAboutDeprecatedCJSRequire.js:17 Warning: Please use `require("history").createBrowserHistory` instead of `require("history/createBrowserHistory")`. Support for the latter will be removed in the next major release. ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looks like we have some CI failures to fix.
Not sure if the failures are public. Here's what's failing: From
From
|
The import method for history required an update to v4.9.0.
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 10 10
Lines 218 218
Branches 48 48
=======================================
Hits 174 174
Misses 30 30
Partials 14 14
Continue to review full report at Codecov.
|
Removed spaces.
Updated. Hopefully it works! |
@KevinGrandon Can someone double-check the build? I've updated the code but it's still failing. I can't access the details of the failures because the pages 404. Some help would be appreciated on this. |
We will work on exposing the public page more easily, but for now you should be able to see the failing task and reproduce locally. I was looking into the flow failure a bit for this and ended up submitting: flow-typed/flow-typed#3306 Trying those definitions out in: #251 |
The method of importing createBrowserHistory with
import createBrowserHistory from 'history/createBrowserHistory'
causes warning messages during testing. The message produced below includes an example of how to import thecreateBrowserHistory
function. This change updates the code to be compatible with the intent of the message.