Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Note temporary webpack issue #77

Closed
wants to merge 1 commit into from
Closed

Note temporary webpack issue #77

wants to merge 1 commit into from

Conversation

angus-c
Copy link
Contributor

@angus-c angus-c commented Jan 23, 2019

Resolves #77

@old-fusion-bot old-fusion-bot bot added the docs label Jan 23, 2019

---

### *Temporary Default Service Worker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to have this content in the README? Just wondering if a standalone .js file would be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is we can't use imports in sw.js right now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively we add it to the scaffold, but that won't help externals

@chrisdothtml
Copy link
Member

Resolves #76 not #77 right? 😀

Also, is there a link you could provide to the webpack issue?

@angus-c
Copy link
Contributor Author

angus-c commented Jan 23, 2019

Ok I think I'll abandon this one

@angus-c angus-c closed this Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants