Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scanner/windows): add Windows Server 2025 and 2022, 23H2 #2059

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

add Windows Server 2025 and Windows Server 2022, 23H2 Edition

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

image

https://www.microsoft.com/en-us/evalcenter/download-windows-server-2025

before

$ vuls scan
...
[Nov  5 19:58:35]  INFO [localhost] Validating config...
[Nov  5 19:58:35]  INFO [localhost] Detecting Server/Container OS... 
[Nov  5 19:58:35]  INFO [localhost] Detecting OS of servers... 
[Nov  5 19:58:36]  INFO [localhost] (1/1) Detected: windows-server: windows Windows Server 2022
[Nov  5 19:58:36]  INFO [localhost] Detecting OS of containers... 
[Nov  5 19:58:36]  INFO [localhost] Checking Scan Modes... 
[Nov  5 19:58:36]  INFO [localhost] Detecting Platforms... 
[Nov  5 19:58:40]  INFO [localhost] (1/1) windows-server is running on other


Scan Summary
================
windows-server	windowsWindows Server 2022	3 installed, 0 updatable





To view the detail, vuls tui is useful.
To send a report, run vuls report -h.

after

$ vuls scan
...
[Nov  5 19:49:32]  INFO [localhost] Validating config...
[Nov  5 19:49:32]  INFO [localhost] Detecting Server/Container OS... 
[Nov  5 19:49:32]  INFO [localhost] Detecting OS of servers... 
[Nov  5 19:49:33]  INFO [localhost] (1/1) Detected: windows-server: windows Windows Server 2025
[Nov  5 19:49:33]  INFO [localhost] Detecting OS of containers... 
[Nov  5 19:49:33]  INFO [localhost] Checking Scan Modes... 
[Nov  5 19:49:33]  INFO [localhost] Detecting Platforms... 
[Nov  5 19:49:36]  INFO [localhost] (1/1) windows-server is running on other


Scan Summary
================
windows-server	windowsWindows Server 2025	3 installed, 0 updatable





To view the detail, vuls tui is useful.
To send a report, run vuls report -h.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n requested a review from shino November 5, 2024 11:22
@MaineK00n MaineK00n self-assigned this Nov 5, 2024
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous!!

I left one not-useful comment, but it's OK to merge even if that is corrected or not!

@MaineK00n MaineK00n merged commit d78018b into master Nov 8, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/windows branch November 8, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants