Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bench)!: move benchmarking facilities to their own crate #208

Merged
merged 1 commit into from
Apr 8, 2024
Merged

refactor(bench)!: move benchmarking facilities to their own crate #208

merged 1 commit into from
Apr 8, 2024

Conversation

ROMemories
Copy link
Collaborator

@ROMemories ROMemories commented Mar 21, 2024 •
edited by kaspar030
Loading

Depends on #206.
Depends on #189.

@ROMemories ROMemories force-pushed the feat/riot-rs-bench branch 3 times, most recently from bf3d4bf to 4b28d55 Compare March 21, 2024 13:13
@ROMemories
Copy link
Collaborator Author

#206 should be merged before this PR

@ROMemories ROMemories mentioned this pull request Mar 21, 2024
Merged
@kaspar030
Copy link
Collaborator

LGTM.

@kaspar030
Copy link
Collaborator

pls squash

@ROMemories ROMemories force-pushed the feat/riot-rs-bench branch 2 times, most recently from 9dae8b1 to 57e418f Compare March 25, 2024 11:19
@ROMemories ROMemories marked this pull request as draft March 25, 2024 14:55
@ROMemories
Copy link
Collaborator Author

Temporarily marking as draft as it's actually unclear what we should do about unsupported architectures

@kaspar030 kaspar030 mentioned this pull request Mar 26, 2024
Merged
@ROMemories
Copy link
Collaborator Author

Unmarking as draft, as this was resolved with #189

@ROMemories ROMemories marked this pull request as ready for review March 26, 2024 11:09
@ROMemories ROMemories marked this pull request as draft March 26, 2024 11:34
@ROMemories ROMemories marked this pull request as ready for review March 26, 2024 13:04
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@kaspar030
Copy link
Collaborator

LGTM!

@ROMemories ROMemories added this pull request to the merge queue Apr 8, 2024
Merged via the queue into future-proof-iot:main with commit 3034268 Apr 8, 2024
16 checks passed
@ROMemories ROMemories deleted the feat/riot-rs-bench branch April 8, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ROMemories @kaspar030