-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
book(dev): document the process for adding new workspace crates #273
base: main
Are you sure you want to change the base?
book(dev): document the process for adding new workspace crates #273
Conversation
Co-authored-by: ROMemories <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subjective opinion: not sure if we really need this section, given that we don't add new crates that often
The first couple of points aren't RIOT-rs specific. Only really the points about rexporting the crate from riot-rs
and adding it (and potential features flag) to the CI are. Maybe it makes sense to have them, but then I'm in favor of shortening it down.
But not a strong opinion :)
Co-authored-by: Elena Frank <[email protected]>
I agree it's not a weekly event, but it does happen quite regularly:
I also agree that not all of it is RIOT-rs-specific, but it helps clarify what tools and configuration we embrace, especially as these are always changing—e.g., inheritance of workspace lints was only added a few months ago and I was personally pleasantly surprised when I saw that using |
Not sure the Coding Conventions is the best place to document this, maybe we should have a book section for documenting processes.