Move CoAP server setup into module #348
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security setup is not moved in yet. Choices of address families are propagated into smoltcp to avoid mismatches.
chrysn
force-pushed
the
coapserver-into-coapcore
branch
from
87e8f7e
to
83d39d9
Compare
25 tasks
This merge rejects some changes from c2859ab: The local changes place all CoAP output into a dedicated message stream. (That stream may contain defmt information at some point, but that'll need more infrastructure).
chrysn
changed the title
4 tasks
ROMemories
reviewed
Aug 20, 2024
| @@ -166,3 +166,7 @@ defmt = [ | |||
| # usb peripheral support. | |||
| stm32-usb = [] | |||
| stm32-usb-synopsis = [] | |||
|
|
|||
| # Made available so that downsteram crates such as riot-rs-coap don't need to | |||
There was a problem hiding this comment.
Suggested change
| # Made available so that downsteram crates such as riot-rs-coap don't need to | |
| # Made available so that downstream crates such as riot-rs-coap don't need to |
ROMemories
reviewed
Aug 20, 2024
| @@ -141,7 +141,7 @@ jobs: | |||
| args: --verbose --locked --features no-boards -p riot-rs -p riot-rs-boards -p riot-rs-chips -p riot-rs-debug -p riot-rs-embassy -p riot-rs-macros -p riot-rs-random -p riot-rs-rt -p riot-rs-threads -p riot-rs-utils | |||
|
|
|||
| - name: rustdoc | |||
| run: RUSTDOCFLAGS='-D warnings' cargo doc -p riot-rs --features no-boards,bench,external-interrupts,threading,random,csprng,hwrng | |||
| run: RUSTDOCFLAGS='-D warnings' cargo doc -p riot-rs --features no-boards,bench,external-interrupts,threading,random,csprng,hwrng,coap,net,usb-ethernet | |||
There was a problem hiding this comment.
Suggested change
| run: RUSTDOCFLAGS='-D warnings' cargo doc -p riot-rs --features no-boards,bench,external-interrupts,threading,random,csprng,hwrng,coap,net,usb-ethernet | |
| run: RUSTDOCFLAGS='-D warnings' cargo doc -p riot-rs --features no-boards,bench,external-interrupts,threading,random,csprng,hwrng,coap,net |
I don't think the usb-ethernet feature should be enabled for documentation, as it does not expose any new items; it's only used for internal behavior selection I think. (Regarding the net feature, I'm not sure yet.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should eventually move all the required shared setup for CoAP into coapcore.
So far, it only moves everything after the socket setup (see open questions)
Issues/PRs references
Depends on #346.
Contributes-To: #340
Open Questions
Where is the socket setup best moved? My current approach would be to have a new riot-rs-coapcore crate that does the integration (might alsmost be embassy-net-coapcore, but we'll also pull in the RNG in that step).
Is there any better way to do what is effectively an async callback than by introducing a trait in lib.rs? (I've spent about 1h fighting the borrow checker, concluding that I'd probably need a generic associated type like
where for<'a> ClientOps: Fn(...) -> ClientFuture<'a>, ClientFuture<'a>: Future, but Rust can't do that).Change checklist