-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): re-export crates under riot_rs::reexports::*
#408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaf9
requested changes
Sep 11, 2024
kaspar030
force-pushed
the
reexports
branch
from
September 11, 2024 08:05
f24db87
to
6626e8a
Compare
kaspar030
commented
Sep 11, 2024
kaspar030
force-pushed
the
reexports
branch
2 times, most recently
from
September 11, 2024 10:39
46290c7
to
49881f8
Compare
ROMemories
reviewed
Sep 11, 2024
ROMemories
reviewed
Sep 13, 2024
elenaf9
approved these changes
Sep 13, 2024
kaspar030
force-pushed
the
reexports
branch
2 times, most recently
from
September 16, 2024 13:26
a18af74
to
87481e3
Compare
|
kaspar030
force-pushed
the
reexports
branch
from
September 16, 2024 20:23
2ecc35c
to
87481e3
Compare
kaspar030
force-pushed
the
reexports
branch
from
September 17, 2024 11:17
af07d7a
to
555b181
Compare
ROMemories
approved these changes
Sep 17, 2024
kaspar030
changed the title
feat(build): re-export crates under
feat(build): re-export crates under Sep 17, 2024
riot_rs::crates::*
riot_rs::reexports::*
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed at this week's weekly meeting, this PR starts the process of having all crates as used by riot-rs available for importing at
riot_rs::crates::*
.I went with
crates
vs. re-exports to clarify that the namespace is reserved for crates, compared to re-exporting specific parts of a crate's api.This PR tries to not do anything else, like, moving around imports, other than for introducing
riot_rs::crates
.Issues/PRs references
Open Questions
Change checklist