Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): re-export crates under riot_rs::reexports::* #408

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kaspar030
Copy link
Collaborator

@kaspar030 kaspar030 commented Sep 11, 2024

Description

As discussed at this week's weekly meeting, this PR starts the process of having all crates as used by riot-rs available for importing at riot_rs::crates::*.

I went with crates vs. re-exports to clarify that the namespace is reserved for crates, compared to re-exporting specific parts of a crate's api.

This PR tries to not do anything else, like, moving around imports, other than for introducing riot_rs::crates.

Issues/PRs references

Open Questions

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

@kaspar030 kaspar030 force-pushed the reexports branch 2 times, most recently from 46290c7 to 49881f8 Compare September 11, 2024 10:39
@kaspar030 kaspar030 marked this pull request as ready for review September 11, 2024 10:40
src/riot-rs-macros/src/task.rs Show resolved Hide resolved
src/riot-rs-embassy/src/lib.rs Outdated Show resolved Hide resolved
src/riot-rs-embassy/src/lib.rs Outdated Show resolved Hide resolved
src/riot-rs/src/lib.rs Show resolved Hide resolved
src/riot-rs/src/lib.rs Outdated Show resolved Hide resolved
examples/embassy-usb-keyboard/src/main.rs Outdated Show resolved Hide resolved
src/riot-rs/src/lib.rs Outdated Show resolved Hide resolved
@kaspar030 kaspar030 force-pushed the reexports branch 2 times, most recently from a18af74 to 87481e3 Compare September 16, 2024 13:26
@kaspar030
Copy link
Collaborator Author

  • changed to use reexports vs crates

@ROMemories ROMemories added this pull request to the merge queue Sep 17, 2024
Merged via the queue into future-proof-iot:main with commit 40bb4c7 Sep 17, 2024
26 checks passed
@kaspar030 kaspar030 changed the title feat(build): re-export crates under riot_rs::crates::* feat(build): re-export crates under riot_rs::reexports::* Sep 17, 2024
@kaspar030 kaspar030 deleted the reexports branch September 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants