Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runqueue): implement Default now that hax supports it #414

Merged
merged 1 commit into from
Sep 17, 2024
Merged

refactor(runqueue): implement Default now that hax supports it #414

merged 1 commit into from
Sep 17, 2024

Conversation

ROMemories
Copy link
Collaborator

@ROMemories ROMemories commented Sep 13, 2024 •
edited
Loading

Description

Support for Default has been added in hacspec/hax#891

Issues/PRs references

Open Questions

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

@ROMemories ROMemories marked this pull request as draft September 13, 2024 07:17
@ROMemories
Copy link
Collaborator Author

This usage of Default actually seems to not yet be supported by hax: hacspec/hax#585 (comment)

@ROMemories ROMemories force-pushed the refactor/impl-default-on-runqueue branch 2 times, most recently from 5ecbf62 to 663d0a8 Compare September 16, 2024 15:20
@ROMemories
Copy link
Collaborator Author

The F* model of Default has been fixed in hax: hacspec/hax#891

@ROMemories ROMemories marked this pull request as ready for review September 17, 2024 07:06
@kaspar030 kaspar030 added this pull request to the merge queue Sep 17, 2024
@ROMemories ROMemories removed this pull request from the merge queue due to a manual request Sep 17, 2024
@ROMemories ROMemories force-pushed the refactor/impl-default-on-runqueue branch from 663d0a8 to 7715e01 Compare September 17, 2024 07:12
@kaspar030 kaspar030 added this pull request to the merge queue Sep 17, 2024
Merged via the queue into future-proof-iot:main with commit 0c24d1d Sep 17, 2024
26 checks passed
@elenaf9 elenaf9 mentioned this pull request Sep 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenaf9 elenaf9 elenaf9 approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ROMemories @kaspar030 @elenaf9