refactor(runqueue-clist): use peek_head as much as possible
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMemories
commented
Sep 19, 2024
ROMemories
commented
Sep 19, 2024
elenaf9
approved these changes
Sep 20, 2024
ROMemories
force-pushed
the
refactor/peek-head-in-runqueue
branch
from
c727c5c
to
27007e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very small refactor of the runqueue's
CListwhich re-uses internal functions as much as possible while preserving performance.It's an attempt to simplify its implementation to ease future refactors possibly required for formally verifying it.
Testing
I obtained the exact same results for the
bench_sched_yieldbenchmark before and after this PR.Issues/PRs references
Open Questions
Change checklist