Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump esp-hal to v0.21.0 #442

Merged
merged 5 commits into from
Oct 16, 2024
Merged

bump esp-hal to v0.21.0 #442

merged 5 commits into from
Oct 16, 2024

Conversation

kaspar030
Copy link
Collaborator

@kaspar030 kaspar030 commented Sep 26, 2024

Description

Bumps esp-hal to 0.21.0 + our patches.

Issues/PRs references

Depends on #399.

Open Questions

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

@kaspar030
Copy link
Collaborator Author

With this, WiFi now works on the esp32-wroom-32!

@ROMemories
Copy link
Collaborator

esp-hal just released v0.21.0 🎉

@kaspar030
Copy link
Collaborator Author

This cargo-deny error seems like a bug:

INFO resolve: Resolving package: 'cargo-deny'
 WARN The package cargo-deny v0.16.1 (x86_64-unknown-linux-musl) has been downloaded from github.com
 INFO This will install the following binaries:
 INFO   - cargo-deny (cargo-deny -> /home/runner/.cargo/bin/cargo-deny)
 INFO Installing binaries...
 INFO Done in 1.838378756s
thread '<unnamed>' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/krates-0.17.1/src/builder.rs:718:25:
internal error: entered unreachable code: unable to locate defmt-03 for crate registry+https://github.com/rust-lang/crates.io-index#[email protected] features(["unproven"])
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Error: Process completed with exit code 101.

@kaspar030 kaspar030 marked this pull request as ready for review October 14, 2024 13:36
@kaspar030
Copy link
Collaborator Author

I've tested examples/embassy-http-server with the c6, plain esp32 and the s3. s3 goes into a boot loop, but also does so on main.

Copy link
Collaborator

@ROMemories ROMemories left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested examples/gpio and examples-http-server on esp32c6.
LGTM!

src/riot-rs-esp/src/i2c/controller/mod.rs Show resolved Hide resolved
@ROMemories ROMemories added the arch Architecture support label Oct 16, 2024
@kaspar030 kaspar030 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into future-proof-iot:main with commit f009897 Oct 16, 2024
25 of 26 checks passed
@kaspar030 kaspar030 deleted the esp32 branch October 16, 2024 07:51
ROMemories added a commit to ROMemories/RIOT-rs that referenced this pull request Oct 17, 2024
`#!feature(trait_alias)` was previously required but is not anymore
since future-proof-iot#442.
ROMemories added a commit to ROMemories/RIOT-rs that referenced this pull request Oct 17, 2024
`#![feature(trait_alias)]` was previously required but is not anymore
since future-proof-iot#442.
elenaf9 pushed a commit to elenaf9/RIOT-rs that referenced this pull request Oct 22, 2024
`#![feature(trait_alias)]` was previously required but is not anymore
since future-proof-iot#442.
@elenaf9
Copy link
Collaborator

elenaf9 commented Oct 22, 2024

Unfortunately this PR broke threading for xtensa, not sure why. Both threading examples don't work anymore on main, but still worked on the commit before this PR.

elenaf9 pushed a commit to elenaf9/RIOT-rs that referenced this pull request Oct 25, 2024
`#![feature(trait_alias)]` was previously required but is not anymore
since future-proof-iot#442.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch Architecture support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants