Add notification rule tests

futurice · Jul 29, 2024 · 2d84045 · 2d84045
1 parent 5c75248
commit 2d84045
Show file tree

Hide file tree

Showing 4 changed files with 484 additions and 1 deletion.
diff --git a/internal/provider/notificationpublisher/notification_publisher_resource.go b/internal/provider/notificationpublisher/notification_publisher_resource.go
@@ -236,7 +236,7 @@ func DTPublisherToTFPublisher(ctx context.Context, dtPublisher dtrack.Notificati
 		Template:         types.StringValue(dtPublisher.Template),
 	}
 
-	// normalize the description to null to allow the attribute to be optional
+	// normalize to null to allow the attribute to be optional
 	if len(dtPublisher.Description) > 0 {
 		publisher.Description = types.StringValue(dtPublisher.Description)
 	} else {

diff --git a/internal/provider/notificationrule/notification_rule_resource.go b/internal/provider/notificationrule/notification_rule_resource.go
@@ -72,6 +72,9 @@ func (r *NotificationRuleResource) Schema(ctx context.Context, req resource.Sche
 			"scope": schema.StringAttribute{
 				MarkdownDescription: "Rule scope. Possible values: [PORTFOLIO, SYSTEM]",
 				Required:            true,
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.RequiresReplace(),
+				},
 			},
 			"notification_level": schema.StringAttribute{
 				MarkdownDescription: "Notification level. Possible values: [INFORMATIONAL, WARNING, ERROR]",
@@ -266,6 +269,13 @@ func DTRuleToTFRule(ctx context.Context, dtRule dtrack.NotificationRule) (Notifi
 		PublisherConfig:      types.StringValue(dtRule.PublisherConfig),
 	}
 
+	// normalize to null to allow the attribute to be optional
+	if len(dtRule.PublisherConfig) > 0 {
+		rule.PublisherConfig = types.StringValue(dtRule.PublisherConfig)
+	} else {
+		rule.PublisherConfig = types.StringNull()
+	}
+
 	rule.NotifyOn, diags = types.SetValueFrom(ctx, types.StringType, dtRule.NotifyOn)
 
 	return rule, diags