Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contented-pipeline-md): restrict what directive can be parsed #623

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

fuxingloh
Copy link
Owner

What this PR does / why we need it:

As per title—directive features should be further limited to approved components and components design or what's already defined in GFM.

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for contented ready!

Name Link
🔨 Latest commit 030359c
🔍 Latest deploy log https://app.netlify.com/sites/contented/deploys/65155e46a7eb3300087781fe
😎 Deploy Preview https://deploy-preview-623--contented.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the kind/chore Non feature change label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #623 (030359c) into main (0551e1b) will increase coverage by 5.36%.
Report is 62 commits behind head on main.
The diff coverage is 96.74%.

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   85.00%   90.36%   +5.36%     
==========================================
  Files          10       13       +3     
  Lines         420      519      +99     
  Branches       73      100      +27     
==========================================
+ Hits          357      469     +112     
+ Misses         63       50      -13     
Files Coverage Δ
...ented-pipeline-jest-md/src/JestMarkdownPipeline.ts 100.00% <100.00%> (ø)
...ages/contented-pipeline-md/src/MarkdownPipeline.ts 85.29% <100.00%> (ø)
...ages/contented-pipeline-md/src/UnifiedProcessor.ts 87.09% <100.00%> (-0.41%) ⬇️
...contented-pipeline-md/src/plugins/RehypeHeading.ts 93.54% <ø> (+6.45%) ⬆️
...contented-pipeline-md/src/plugins/RehypeMermaid.ts 75.00% <ø> (+31.25%) ⬆️
...ntented-pipeline-md/src/plugins/RemarkCodeblock.ts 100.00% <100.00%> (ø)
...d-pipeline-md/src/plugins/RemarkDirectiveRehype.ts 100.00% <100.00%> (ø)
...es/contented-pipeline-md/src/plugins/RemarkLink.ts 100.00% <100.00%> (+28.57%) ⬆️
...ages/contented-processor/src/ContentedProcessor.ts 88.46% <100.00%> (+2.04%) ⬆️
...s/contented-pipeline-md/src/plugins/RehypeShiki.ts 96.77% <96.77%> (ø)
... and 2 more

@fuxingloh fuxingloh marked this pull request as ready for review September 28, 2023 11:11
@fuxingloh fuxingloh merged commit 50e71f3 into main Sep 28, 2023
12 checks passed
@fuxingloh fuxingloh deleted the fuxing/restrict-attributes branch September 28, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant