Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contented): add image processing #634

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

fuxingloh
Copy link
Owner

@fuxingloh fuxingloh commented Oct 10, 2023

What this PR does / why we need it:

Add images support for contented.

Image commonly used in Markdown is supported but with some caveats. Contented being a prose-bundler is designed to bundle prose such that it is portable and can be deployed to different sites or domains. This makes it difficult to support images that are not bundled together with the prose. To get around this, all local images are embedded into the Markdown file as base64 encoded strings. Remote images are left as is.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for contented ready!

Name Link
🔨 Latest commit 5297d62
🔍 Latest deploy log https://app.netlify.com/sites/contented/deploys/65254b5b60c7370008a43a00
😎 Deploy Preview https://deploy-preview-634--contented.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fuxingloh fuxingloh marked this pull request as ready for review October 10, 2023 13:04
@fuxingloh fuxingloh merged commit bc67628 into main Oct 10, 2023
11 checks passed
@fuxingloh fuxingloh deleted the fuxing/remark-embed-images branch October 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant