Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SD-126] Save model summary during benchmarking #53
[SD-126] Save model summary during benchmarking #53
Changes from 6 commits
2d1fdc3
6d9c089
129f045
2623a30
3d26770
f7a836d
0827c54
2596baf
62320fa
b1827ee
e7b1d38
cebcb44
0779eb1
60cb54a
c75d7b0
c69ba76
caae6e6
668505b
65459ba
313099d
e173da3
c79ea8b
b164482
a33d191
773e00b
0a10fe6
3d47471
67436b1
05554c2
ddfe693
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top level comment: I'd split this file into a script under power_logging and the utility functions left here.
Just so that it can be properly called from the top level package (and the instructions for it included in the README)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On top of that. We should have a bash script that would run the said script for all the models and save the results to raw_data/prebuilt_models/{model_name}/model_summary.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv needs locking dependencies again, after removing torchsummary from the dependencies list
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.