Remove mergable badge

src/components/PullRequestStatus.tsx

@@ -23,18 +23,6 @@ const DRAFT = (
   </Badge>
 );
 
-const MERGEABLE = (
-  <Badge pill bg="success" key="mergeable">
-    Mergeable
-  </Badge>
-);
-
-const NOT_MERGEABLE = (
-  <Badge pill bg="danger" key="not_mergeable">
-    Mergeable
-  </Badge>
-);
-
 const MERGED = (
   <Badge pill bg="" style={{ backgroundColor: "#8259DD" }} key="merged">
     Merged
@@ -138,7 +126,6 @@ function getIncomingStateBadges(state: PullRequestState): JSX.Element[] {
     badges.push(AUTHOR_REPLIED);
   }
 
-  badges.push(state.mergeable ? MERGEABLE : NOT_MERGEABLE);
   badges.push(...getCheckStatusBadge(state.checkStatus));
 
   return badges;
@@ -160,7 +147,6 @@ function getOutgoingStateBadges(state: PullRequestState): JSX.Element[] {
     badges.push(NEEDS_REVIEW);
   }
 
-  badges.push(state.mergeable ? MERGEABLE : NOT_MERGEABLE);
   badges.push(...getCheckStatusBadge(state.checkStatus));
 
   return badges;

src/filtering/status.spec.ts

@@ -190,7 +190,6 @@ describe("pullRequestState", () => {
       draft: false,
       noReviewers: true,
       changesRequested: false,
-      mergeable: false,
       approved: false,
     });
 
@@ -204,7 +203,6 @@ describe("pullRequestState", () => {
       draft: true,
       noReviewers: true,
       changesRequested: false,
-      mergeable: false,
       approved: false,
     });
 
@@ -222,7 +220,6 @@ describe("pullRequestState", () => {
       draft: false,
       noReviewers: false,
       changesRequested: false,
-      mergeable: false,
       approved: false,
     });
 
@@ -234,7 +231,6 @@ describe("pullRequestState", () => {
           .addReview("kevin", "CHANGES_REQUESTED")
           .addComment("fwouts")
           .addReview("kevin", "APPROVED")
-          .mergeable()
           .seenAs("fwouts")
           .build(),
         "fwouts"
@@ -244,7 +240,6 @@ describe("pullRequestState", () => {
       draft: false,
       noReviewers: false,
       changesRequested: false,
-      mergeable: true,
       approved: false,
     });
 
@@ -266,7 +261,6 @@ describe("pullRequestState", () => {
       draft: false,
       noReviewers: false,
       changesRequested: false,
-      mergeable: false,
       approved: true,
     });
 
@@ -288,7 +282,6 @@ describe("pullRequestState", () => {
       draft: false,
       noReviewers: false,
       changesRequested: false,
-      mergeable: false,
       approved: false,
     });
 
@@ -310,7 +303,6 @@ describe("pullRequestState", () => {
       draft: false,
       noReviewers: false,
       changesRequested: false,
-      mergeable: false,
       approved: false,
     });
   });

src/filtering/status.ts

@@ -64,7 +64,6 @@ function incomingPullRequestState(
     authorResponded: hasReviewed && hasNewCommentByAuthor,
     checkStatus: pr.checkStatus,
     changesRequested: states.has("CHANGES_REQUESTED") || !pr.reviewRequested,
-    mergeable: pr.mergeable === true,
     approved: false,
     isMerged: pr.isMerged,
   };
@@ -97,7 +96,6 @@ function outgoingPullRequestState(
     kind: "outgoing",
     draft: pr.draft === true,
     changesRequested: states.has("CHANGES_REQUESTED") || !pr.reviewRequested,
-    mergeable: pr.mergeable === true,
     approved: states.has("APPROVED"),
     checkStatus: pr.checkStatus,
     newReviewRequested: states.has("PENDING"),
@@ -112,7 +110,6 @@ export type PullRequestState = {
   changesRequested: boolean;
   draft: boolean;
   kind: "incoming" | "outgoing";
-  mergeable: boolean;
   newReviewRequested: boolean;
   isMerged: boolean;
   checkStatus?: CheckStatus;

src/loading/internal/pull-requests.ts

@@ -5,7 +5,6 @@ import {
   PullRequestStatus,
   RepoReference,
 } from "../../github-api/api";
-import { nonEmptyItems } from "../../helpers";
 import {
   Comment,
   PullRequest,
@@ -35,7 +34,6 @@ export function testPRs(): Promise<PullRequest[]> {
       },
       title: "Codemod old API to new API",
       draft: false,
-      mergeable: true,
       reviewRequested: true,
       requestedReviewers: [],
       requestedTeams: [],
@@ -73,7 +71,6 @@ export function testPRs(): Promise<PullRequest[]> {
       },
       title: "Use new endpoint on homepage",
       draft: false,
-      mergeable: true,
       reviewRequested: true,
       requestedReviewers: [],
       requestedTeams: [],
@@ -105,7 +102,6 @@ export function testPRs(): Promise<PullRequest[]> {
       },
       title: "Use new routing API",
       draft: false,
-      mergeable: true,
       reviewRequested: false,
       requestedReviewers: [],
       requestedTeams: [],
@@ -137,7 +133,6 @@ export function testPRs(): Promise<PullRequest[]> {
       },
       title: "Update unit tests for nav bar",
       draft: true,
-      mergeable: false,
       reviewRequested: true,
       requestedReviewers: [],
       requestedTeams: [],
@@ -169,7 +164,6 @@ export function testPRs(): Promise<PullRequest[]> {
       },
       title: "Ship new accounts page",
       draft: false,
-      mergeable: true,
       reviewRequested: true,
       requestedReviewers: [],
       requestedTeams: [],
@@ -198,7 +192,6 @@ export function testPRs(): Promise<PullRequest[]> {
       },
       title: "Fix bug when scrolling through accounts",
       draft: false,
-      mergeable: true,
       reviewRequested: true,
       requestedReviewers: [],
       requestedTeams: [],
@@ -229,7 +222,6 @@ export function testPRs(): Promise<PullRequest[]> {
       },
       title: "Add caching to queries",
       draft: false,
-      mergeable: true,
       reviewRequested: false,
       requestedReviewers: [],
       requestedTeams: [],
@@ -303,15 +295,13 @@ async function updateCommentsAndReviews(
     number: rawPullRequest.number,
   };
   const [
-    freshPullRequestDetails,
     freshChangeSummary,
     freshReviews,
     freshComments,
     freshReviewComments,
     pullRequestStatus,
     isMerged,
   ] = await Promise.all([
-    githubApi.loadPullRequestDetails(pr),
     githubApi.loadPullRequestChangeSummary(pr),
     githubApi.loadReviews(pr).then((reviews) =>
       reviews.map((review) => ({
@@ -338,7 +328,6 @@ async function updateCommentsAndReviews(
 
   return pullRequestFromResponse(
     rawPullRequest,
-    freshPullRequestDetails,
     freshChangeSummary,
     freshReviews,
     freshComments,
@@ -351,7 +340,6 @@ async function updateCommentsAndReviews(
 
 function pullRequestFromResponse(
   response: RestEndpointMethodTypes["search"]["issuesAndPullRequests"]["response"]["data"]["items"][number],
-  details: RestEndpointMethodTypes["pulls"]["get"]["response"]["data"],
   changeSummary: any,
   reviews: Review[],
   comments: Comment[],
@@ -385,14 +373,7 @@ function pullRequestFromResponse(
     },
     title: response.title,
     draft: response.draft,
-    mergeable: details.mergeable || false,
     reviewRequested,
-    requestedReviewers: nonEmptyItems(
-      details.requested_reviewers?.map((reviewer) => reviewer?.login)
-    ),
-    requestedTeams: nonEmptyItems(
-      details.requested_teams?.map((team) => team?.name)
-    ),
     reviews,
     comments: [...comments, ...reviewComments],
     reviewDecision: status.reviewDecision,

src/storage/loaded-state.ts

@@ -66,7 +66,6 @@ export interface PullRequest {
   };
   title: string;
   draft?: boolean;
-  mergeable?: boolean;
   /**
    * Whether a review is requested from the current user.
    */

src/testing/fake-pr.ts

@@ -28,7 +28,6 @@ class FakePullRequestBuilder {
   private _reviews: Review[] = [];
   private _commits: Commit[] = [];
   private _draft = false;
-  private _mergeable = false;
 
   private _nextTimestamp = 1;
 
@@ -54,11 +53,6 @@ class FakePullRequestBuilder {
     return this;
   }
 
-  mergeable() {
-    this._mergeable = true;
-    return this;
-  }
-
   reviewRequested(logins: string[], teams?: string[]) {
     this._reviewerLogins = logins;
     this._reviewerTeams = teams || [];
@@ -121,15 +115,13 @@ class FakePullRequestBuilder {
       pullRequestNumber: this._ref.number,
       nodeId: `${this._ref.repo.owner}/${this._ref.repo.name}/${this._ref.number}`,
       draft: this._draft,
-      mergeable: this._mergeable,
       updatedAt: "1 June 2019",
       htmlUrl: `http://github.com/${this._ref.repo.owner}/${this._ref.repo.name}/${this._ref.number}`,
       reviewRequested: reviewRequested,
       requestedReviewers: this._reviewerLogins,
       requestedTeams: this._reviewerTeams,
       comments: this._comments,
       reviews: this._reviews,
-      commits: this._commits,
       reviewDecision: "REVIEW_REQUIRED",
     };
   }