-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firmware for SN30 gamepad #18
Open
Felixoid
wants to merge
2
commits into
fwupd:master
Choose a base branch
from
Felixoid:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Copyright (C) 2019 Richard Hughes <[email protected]> | ||
| # Copyright (C) 2019 Mikhail f. Shiryaev <[email protected]> | ||
|
|
||
| VENDOR=8Bitdo | ||
| PROJECT_NAME=SN30_GP | ||
| VERSION=6.11 | ||
| FIRMWARE_FILES=$(wildcard *.dat) | ||
| METAINFO_FILES=sn30gp.metainfo.xml | ||
|
|
||
| all: $(VENDOR)-$(PROJECT_NAME)-$(VERSION).cab | ||
|
|
||
| clean: | ||
| rm *.cab | ||
|
|
||
| check: $(METAINFO_FILES) | ||
| appstream-util validate-relax $(METAINFO_FILES) | ||
|
|
||
| %.cab: $(FIRMWARE_FILES) $(METAINFO_FILES) | ||
| gcab --create --nopath $@ "$(FIRMWARE_FILES)" $(METAINFO_FILES) |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| 2019-05-18 SN30+SF30_Firmware_V6.11 | ||
|
|
||
| 1. Fixed input lag issue with playing SUPER SMASH BROS. | ||
| 2. Fixed the pop-up window error when using amiibo. | ||
|
|
||
| ------------------------------------------------------------------------------- | ||
|
|
||
| Update instruction: | ||
| 1. Press and hold L+R+START buttons on the controller to put it on its update mode. LEDs on the top will blink in red. | ||
| 2. Connect the controller to your Windows or macOS via the USB cable. | ||
| 3. Click on "USB Update" on your device, search for Firmware.dat in the pop-up window and run it. | ||
| 4. Un-plug the controller when the upgrade process is done, then restart it before using. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- Copyright 2016 Richard Hughes <[email protected]> --> | ||
| <!-- Copyright 2018 Mario Limonciello <[email protected]> --> | ||
| <component type="firmware"> | ||
| <id>com.8bitdo.sn30-gp.firmware</id> | ||
| <name>SN30 GP</name> | ||
| <summary>Firmware for the 8Bitdo SN30 GP Game Controller</summary> | ||
| <description> | ||
| <p> | ||
| Updating the firmware on your SN30 GP device improves performance and adds | ||
| new features. | ||
| </p> | ||
| </description> | ||
| <provides> | ||
| <!-- USB\VID_2DC8&PID_5750&REV_0200 --> | ||
| <firmware type="flashed">78acf201-a624-5c0b-a521-e204be14e3d5</firmware> | ||
| <!-- USB\VID_2dC8&PID_5750 --> | ||
| <firmware type="flashed">b02f1319-c1c4-54f4-b7f2-5bb3552f6a9e</firmware> | ||
| </provides> | ||
| <url type="homepage">http://www.8bitdo.com/sn30-gp/</url> | ||
| <metadata_license>CC0-1.0</metadata_license> | ||
| <project_license>Proprietary</project_license> | ||
| <developer_name>8Bitdo</developer_name> | ||
| <releases> | ||
| <release urgency="medium" version="6.11" date="2018-12-06"> | ||
| <checksum filename="SN30_Firmware_V6.11.dat" target="content"/> | ||
| <description> | ||
| <p> | ||
| This stable release fixes the following issues: | ||
| </p> | ||
| <ul> | ||
| <li>Fixed input lag issue with playing SUPER SMASH BROS.</li> | ||
| <li>Fixed the pop-up window error when using amiibo.</li> | ||
| </ul> | ||
| </description> | ||
| </release> | ||
| </releases> | ||
| <screenshots> | ||
| <screenshot type="default"> | ||
| <image type="source">http://support.8bitdo.com/images/support/products/sn30-color.gif</image> | ||
| <caption>Unplug the controller, hold down L1 + R1 + START until the red LED on top of the controller is flashing and then reconnect the controller.</caption> | ||
| </screenshot> | ||
| </screenshots> | ||
|
|
||
| <!-- only newer versions of fwupd know about the new controller --> | ||
| <requires> | ||
| <id compare="ge" version="1.0.3">org.freedesktop.fwupd</id> | ||
| </requires> | ||
|
|
||
| <categories> | ||
| <category>X-Device</category> | ||
| </categories> | ||
| <custom> | ||
| <value key="LVFS::UpdateProtocol">com.8bitdo</value> | ||
| </custom> | ||
| </component> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use the bootloader UUID—use the UUID when the device is in Android (D-input) mode. See #25 (comment) for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Richard, this device isn't shown up in the
sudo fwupdmgr get-devices --show-all-devicesoutput in any mode except bootloader. If you would be so nice and point, how to do it, I'll make it for sureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the SN30 GP is affected by fwupd/fwupd#1681. Do you see the same "failed to add USB device" error when you plug it in in D-input mode? If so there's not much that can be done until that bug is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you will need to add an entry for the SN30 GP to https://github.com/fwupd/fwupd/blob/master/plugins/ebitdo/ebitdo.quirk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's the same thing since I don't see errors in fwupd daemon logs
and udevadm monitor
Here's an example of working M30 logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried building fwupd with an entry for the SN30 GP in
ebitdo.quirk?Also, your logs only show libusb messages. Please enable verbose logging (
VerboseDomains=*) to get fwupd log messages.