[PHEE-708] Events batching in Importer RDBMS. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anover000
force-pushed
the
batchingEvents
branch
from
4447c2f to
a275727
Compare
Anover000
force-pushed
the
batchingEvents
branch
from
b8a5df2 to
84edbec
Compare
fynmanoj
requested changes
Jul 18, 2024
| .windowedBy(SessionWindows.ofInactivityGapAndGrace(Duration.ofSeconds(aggregationWindowSeconds), Duration.ZERO)) | ||
| .aggregate(ArrayList::new, aggregator, merger, Materialized.with(STRING_SERDE, ListSerde(ArrayList.class, STRING_SERDE))) | ||
| .groupBy((key, value) -> extractCompositeKey(value)) | ||
| .windowedBy(TimeWindows.of(Duration.ofMillis(300)).grace(Duration.ofMillis(100))) |
There was a problem hiding this comment.
Can we make this time configurable so that this can be fine tuned externally
| private String extractCompositeKey(String value) { | ||
| DocumentContext documentContext = JsonPathReader.parse(value); | ||
| String workflowInstanceKey = documentContext.read("value.processInstanceKey").toString(); | ||
| String recordType = documentContext.read("valueType").toString(); |
| @@ -206,6 +217,10 @@ public void process(Object _key, Object _value) { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| if (valueType.equals("VARIABLE")) { | |||
There was a problem hiding this comment.
I am not clear with this 'break' here. Are we searching for variable?
|
|
||
| @Override | ||
| public Serializer<JsonArray> serializer() { | ||
| return new JsonArraySerializer(); |
There was a problem hiding this comment.
Can we save this instance and re-use?
|
|
||
| @Override | ||
| public Deserializer<JsonArray> deserializer() { | ||
| return new JsonArrayDeserializer(); |
There was a problem hiding this comment.
Can we save this instance and re-use?
|
|
||
| Object object; | ||
|
|
||
| if ("TRANSFER".equalsIgnoreCase(flowType)) { |
There was a problem hiding this comment.
Can you use switch here? And use an ENUM for the flow type
|
|
||
| String variableName = recordDocument.read("$.value.name", String.class); | ||
| String variableValue = recordDocument.read("$.value.value", String.class); | ||
| String value = variableValue.startsWith("\"") && variableValue.endsWith("\"") ? StringEscapeUtils.unescapeJson(variableValue.substring(1, variableValue.length() - 1)) : variableValue; |
There was a problem hiding this comment.
This code has enough context to be moved into a method
|
|
||
| matchingTransformers.forEach(transformer -> applyTransformer(object, variableName, value, transformer)); | ||
|
|
||
| if ("TRANSFER".equalsIgnoreCase(flowType)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHEE-708 Events batching in Importer RDBMS.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Create/update unit or integration tests for verifying the changes made.
Add required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing