Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for no_metadata tag #41

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 8, 2025

This was added in v2.5.0 but not added to the docs. Adding it now and updating my apps to use it.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks.
However I struggled to parse the sentence - it kindof assumes that people know runtime metadata lookup is off for release - I wonder if that part isn't hugely relevant? If it is can it be expressed in a way that is more explicit?

@Jacalz
Copy link
Member Author

Jacalz commented Jan 9, 2025

I kind of struggled with how to write it or be honest. Saying that it disables all metadata would be wrong as anything bundled by cmd/fyne will still work, I think.

@andydotxyz
Copy link
Member

How about "Disable runtime lookup of metadata from FyneApp.toml source files. This is always disabled for release builds."

@Jacalz
Copy link
Member Author

Jacalz commented Jan 9, 2025

Sounds splendid :)

@Jacalz Jacalz requested a review from andydotxyz January 9, 2025 12:50
@Jacalz Jacalz merged commit 82a317c into fyne-io:main Jan 9, 2025
@Jacalz Jacalz deleted the no_metadata branch January 9, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants