Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image updates - maintenance release #55

Merged
merged 23 commits into from
Jan 19, 2025
Merged

Conversation

lucor
Copy link
Member

@lucor lucor commented Dec 28, 2024

This PR provides a maintenance release for the docker images.

Note: requires fyne-cross 2.6.1 fyne-io/fyne-cross#289

base image:

darwin image

  • verify Zig archives using minisign

Note: this is the only image that need to use Zig v0.9.1 to cross compile. See ziglang/zig#20689. Also we need to note that we are able to support only MacOS SDK 11.3
Relates to #46

darwin-sdk-extractor

  • update build.zig to support Zig 0.13.0 syntax

freebsd

web

@Jacalz
Copy link
Member

Jacalz commented Jan 2, 2025

Last time I was testing non-released fyne-cross images I had some trouble. What is the best way to force fyne-cross into using these?

@Jacalz Jacalz requested review from Jacalz and andydotxyz January 2, 2025 16:27
@lucor
Copy link
Member Author

lucor commented Jan 2, 2025

Probably the best way is to checkout the PR branch and build the images locally, then fyne-cross should use the local images.

Noticed the CI failures, I'll have a look at them.

lucor added 2 commits January 7, 2025 19:11
openjdk 11 is not available in bookworm. This commit updates the version
to the default one.
lucor added a commit to lucor/fyne-io-fyne-cross that referenced this pull request Jan 8, 2025
This commit updates the destination folder to wasm.
Fixes:
- fyne-io/fyne-cross-images#50
- fyne-io/fyne-cross-images#55
lucor added a commit to lucor/fyne-io-fyne-cross that referenced this pull request Jan 11, 2025
This commit updates the destination folder to wasm.
Fixes:
- fyne-io/fyne-cross-images#50
- fyne-io/fyne-cross-images#55
@Jacalz
Copy link
Member

Jacalz commented Jan 12, 2025

I suppose that an update to the fyne-cross command should make the web CI work?

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to get the web image updated as it is currently installing Go 1.17 (which does not compile with Fyne any more) and it does install GopherJS which we no longer support. We have to get the web image update

@Jacalz
Copy link
Member

Jacalz commented Jan 12, 2025

I can't get my Fedora Silverblue 41 installation to use the locally built images; it just pulls the latest tagged once when I try to use it. Anyway, images built fine :)

EDIT: It does at least install gopherJS which it doesn't need to do. The entire image seems to not be needed for other than backwords-compat reasons actually.

@lucor
Copy link
Member Author

lucor commented Jan 13, 2025

We have to get the web image updated as it is currently installing Go 1.17 (which does not compile with Fyne any more) and it does install GopherJS which we no longer support. We have to get the web image update

Indeed, was waiting for the fyne-cross updates :)
Fixed in 2506c71. The web image is now a tag to the base one.

@lucor
Copy link
Member Author

lucor commented Jan 13, 2025

I can't get my Fedora Silverblue 41 installation to use the locally built images; it just pulls the latest tagged once when I try to use it. Anyway, images built fine :)

That's unfortunate :(. We should look into it. In the meantime, a dev-<image-name> (e.g., dev-linux) should be tagged locally and can be used with the --image flag.

Happy to hear all images built correctly :)

@lucor lucor requested a review from Jacalz January 13, 2025 19:52
@lucor
Copy link
Member Author

lucor commented Jan 13, 2025

CI is happy now with the required fyne-cross 2.6.1@develop fyne-io/fyne-cross#289.
Once the new version of fyne-cross is released, we need to update the version in this PR

@lucor lucor mentioned this pull request Jan 13, 2025
3 tasks
@andydotxyz
Copy link
Member

Good plan, maybe the release can land later today and all of this can come together :)

lucor added 3 commits January 19, 2025 18:12
The docker images is not available for arm64. This commit moves to the
release package from GitHub that ships with the binaries for amd64 and
arm64
@lucor lucor merged commit fe43f4c into fyne-io:main Jan 19, 2025
16 checks passed
@lucor
Copy link
Member Author

lucor commented Jan 19, 2025

Ready for the release 🎉
Thanks all for feedback and testing!
@Bluebugs the CI feature for the arm64 host support landed just in time to catch a last minute release bug :)

@lucor lucor mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants