Hide empty spaces where validation is enabled but nothing to show (#5485

)

widget/entry_validation.go

@@ -60,9 +60,10 @@ func (e *Entry) setValidationError(err error) bool {
 		return false
 	}
 
+	changed := e.validationError != err
 	e.validationError = err
 
-	if e.onValidationChanged != nil {
+	if e.onValidationChanged != nil && changed {
 		e.onValidationChanged(err)
 	}
 

widget/form.go

@@ -26,6 +26,7 @@ type FormItem struct {
 	validationError error
 	invalid         bool
 	helperOutput    *canvas.Text
+	wasFocused      bool
 }
 
 // NewFormItem creates a new form item with the specified label text and input widget
@@ -351,16 +352,28 @@ func (f *Form) updateHelperText(item *FormItem) {
 		return // testing probably, either way not rendered yet
 	}
 	showHintIfError := false
-	if e, ok := item.Widget.(*Entry); ok && (!e.dirty || e.focused) {
-		showHintIfError = true
+	if e, ok := item.Widget.(*Entry); ok {
+		if !e.dirty || (e.focused && !item.wasFocused) {
+			showHintIfError = true
+		}
+		if e.dirty && !e.focused {
+			item.wasFocused = true
+		}
 	}
+
 	if item.validationError == nil || showHintIfError {
 		item.helperOutput.Text = item.HintText
 		item.helperOutput.Color = th.Color(theme.ColorNamePlaceHolder, v)
 	} else {
 		item.helperOutput.Text = item.validationError.Error()
 		item.helperOutput.Color = th.Color(theme.ColorNameError, v)
 	}
+
+	if item.helperOutput.Text == "" {
+		item.helperOutput.Hide()
+	} else {
+		item.helperOutput.Show()
+	}
 	item.helperOutput.Refresh()
 }
 
@@ -472,5 +485,11 @@ func (f formItemLayout) MinSize(objs []fyne.CanvasObject) fyne.Size {
 	min1 := objs[1].MinSize()
 
 	minWidth := fyne.Max(min0.Width, min1.Width)
-	return fyne.NewSize(minWidth, min0.Height+min1.Height+innerPad)
+	height := min0.Height
+
+	items := objs[1].(*fyne.Container).Objects
+	if len(items) > 0 && items[0].(*canvas.Text).Text != "" {
+		height += min1.Height + innerPad
+	}
+	return fyne.NewSize(minWidth, height)
 }

widget/form_test.go

@@ -177,12 +177,15 @@ func TestForm_Hints(t *testing.T) {
 	w := test.NewWindow(form)
 	defer w.Close()
 
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/hint_initial.png", w.Canvas().Capture())
 
 	test.Type(entry2, "n")
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/hint_invalid.png", w.Canvas().Capture())
 
 	test.Type(entry2, "ot-")
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/hint_valid.png", w.Canvas().Capture())
 }
 
@@ -301,24 +304,29 @@ func TestForm_Disable_Validation(t *testing.T) {
 	w := test.NewWindow(form)
 	defer w.Close()
 
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/disable_validation_initial.png", w.Canvas().Capture())
 
 	form.Disable()
 
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/disable_validation_disabled_invalid.png", w.Canvas().Capture())
 
 	form.Enable()
 
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/disable_validation_enabled_invalid.png", w.Canvas().Capture())
 
 	entry.SetText("15-true")
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/disable_validation_enabled_valid.png", w.Canvas().Capture())
 
 	// ensure we don't re-enable the form when entering something valid
 	entry.SetText("invalid")
 	form.Disable()
 	entry.SetText("15-true")
 
+	w.Resize(form.MinSize().Add(fyne.NewSquareSize(theme.Padding() * 2)))
 	test.AssertImageMatches(t, "form/disable_validation_disabled_valid.png", w.Canvas().Capture())
 }