Merge pull request #4433 from Jacalz/build-hints

container/tabs.go

@@ -7,6 +7,7 @@ import (
 	"fyne.io/fyne/v2/canvas"
 	"fyne.io/fyne/v2/driver/desktop"
 	"fyne.io/fyne/v2/internal"
+	"fyne.io/fyne/v2/internal/build"
 	"fyne.io/fyne/v2/theme"
 	"fyne.io/fyne/v2/widget"
 )
@@ -209,7 +210,7 @@ func selectItem(t baseTabs, item *TabItem) {
 }
 
 func setItems(t baseTabs, items []*TabItem) {
-	if internal.HintsEnabled && mismatchedTabItems(items) {
+	if build.HasHints && mismatchedTabItems(items) {
 		internal.LogHint("Tab items should all have the same type of content (text, icons or both)")
 	}
 	t.setItems(items)

internal/build/hints_disabled.go

@@ -0,0 +1,8 @@
+//go:build !hints
+// +build !hints
+
+package build
+
+// HasHints is false to indicate that hints are not currently switched on.
+// To enable please rebuild with "-tags hints" parameters.
+const HasHints = false

internal/build/hints_enabled.go

@@ -0,0 +1,7 @@
+//go:build hints
+// +build hints
+
+package build
+
+// HasHints is true to indicate that hints are currently switched on.
+const HasHints = true

internal/hints_disabled.go

@@ -3,10 +3,6 @@
 
 package internal
 
-// HintsEnabled is false to indicate that hints are not currently switched on.
-// To enable please rebuild with "-tags hints" parameters.
-const HintsEnabled = false
-
 // LogHint reports a developer hint that should be followed to improve their app.
 // This does nothing unless the "hints" build flag is used.
 func LogHint(reason string) {

internal/hints_enabled.go

@@ -8,9 +8,6 @@ import (
 	"runtime"
 )
 
-// HintsEnabled is true to indicate that hints are currently switched on.
-const HintsEnabled = true
-
 // LogHint reports a developer hint that should be followed to improve their app.
 func LogHint(reason string) {
 	log.Println("Fyne hint: ", reason)