-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make data binding thread safe #5361
Conversation
Get/Set can be called from anywhere, Reload too. This is not the final public API, but as drivers needed to add this support first I added it to that interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to see the threading work nearing the finish line! Just a few comments so far
Thanks for the comments, I think that's all good now - with an ongoing discussion for public API for enqueuing functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, so long as we don't care about potential breaking changes on develop
in case we rename or move the new public "CallFromGoroutine" function introduced here
We never care about that. It is one of the reasons to have such a branch. Anyone pulling latest master or release/v2.x.y will never get breaking changes :) But yeah, I agree we need a better name in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice step in the right direction. As discussed inline, we need a better name for the function to queue events but we can tackle that further down the line :)
Get/Set can be called from anywhere, Reload too.
Remove all the tedious waiting in data binding tests.
This is not the final public API for goroutine work, but as drivers needed to add this support first I added it to that interface.
Relates to #4654
Checklist: