Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in test runner #5372

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

andydotxyz
Copy link
Member

Relates to #4654

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

This is a complication our users won't worry about because this package is testing GL and OS connections instead of using the test driver.
@andydotxyz andydotxyz changed the base branch from master to develop January 7, 2025 15:51
@coveralls
Copy link

Coverage Status

coverage: 59.303% (-0.002%) from 59.305%
when pulling 23f68e2 on andydotxyz:fix/racedetection
into 190fe42 on fyne-io:develop.

@andydotxyz andydotxyz marked this pull request as ready for review January 7, 2025 16:59
@andydotxyz andydotxyz changed the title Working to enable race detection in our tests Improvements in test runner Jan 7, 2025
@andydotxyz
Copy link
Member Author

This is 1 of 2 PRs for turning on race. This is just CI fixes that benefit everyone :)

The race detection has highlighted an issue with a race in the test runner / driver itself which will take some more time to resolve.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one possible improvement idea inline :)

internal/driver/glfw/window_test.go Show resolved Hide resolved
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice fixes :)

@Jacalz Jacalz merged commit 8343d80 into fyne-io:develop Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants