Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a bunch of locks that are no longer necessary #5416

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove a bunch of locks that are no longer necessary #5416

merged 1 commit into from
Jan 15, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 15, 2025

Description:

This only leaves locks in the test package (which I suppose are needed?) and those in settings, preferences and bindings.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.142% (+0.02%) from 59.122%
when pulling 9e279e9 on Jacalz:remove.most-remaining-false-locking
into 964a877 on fyne-io:develop.

andydotxyz
andydotxyz approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one thanks

@Jacalz Jacalz merged commit 1b5d475 into fyne-io:develop Jan 15, 2025
12 checks passed
@Jacalz Jacalz deleted the remove.most-remaining-false-locking branch January 15, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacalz @coveralls @andydotxyz