Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup glfw races in app package by respecting the ci flag we removed #5482

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

andydotxyz
Copy link
Member

Removing a race because we're running GLFW app in app tests, which we shouldn't.
The ci tag marks when the code should run in a different mode (in this case for the app package race).

Checklist:

  • Tests included. <- re-enabling an old build feature
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 60.867% (+0.009%) from 60.858%
when pulling 320a431 on andydotxyz:fix/cirace
into 3795a68 on fyne-io:develop.

@andydotxyz andydotxyz merged commit 4e77e09 into fyne-io:develop Jan 30, 2025
11 checks passed
@andydotxyz andydotxyz deleted the fix/cirace branch January 30, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants