Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just resize/move, not refresh content, for Split.SetOffset #5494

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Just resize/move, not refresh content, for Split.SetOffset #5494

merged 2 commits into from
Feb 4, 2025

Conversation

dweymouth
Copy link
Contributor

@dweymouth dweymouth commented Feb 3, 2025 •
edited
Loading

Description:

Split.SetOffset, which is also called by the divider when dragged, no longer refreshes content but just resizes/moves.

Fixes #5488

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Feb 3, 2025 •
edited
Loading

Coverage Status

coverage: 62.641% (+0.02%) from 62.619%
when pulling fe785e6 on dweymouth:efficient-split
into 5ebf631 on fyne-io:develop.

Jacalz
Jacalz reviewed Feb 3, 2025
View reviewed changes
container/split.go Outdated Show resolved Hide resolved
andydotxyz
andydotxyz approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@dweymouth dweymouth merged commit 38596c9 into fyne-io:develop Feb 4, 2025
11 checks passed
@dweymouth dweymouth deleted the efficient-split branch February 4, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz left review comments

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dweymouth @coveralls @andydotxyz @Jacalz