Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GridWrap more efficient by avoiding unnecessary content refreshes when resizing, scrolling #5495

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

dweymouth
Copy link
Contributor

@dweymouth dweymouth commented Feb 3, 2025

Description:

Avoids refreshing content when not necessary during GridWrap.Resize and scrolling. Applies the same optimization from List to only refresh newly visible items unless doing the full Refresh call.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@dweymouth dweymouth marked this pull request as draft February 3, 2025 19:51
@dweymouth dweymouth marked this pull request as ready for review February 3, 2025 19:55
@dweymouth dweymouth changed the title Make GridWrap resizing more efficient by avoiding unnecessary content refreshes Make GridWrap more efficient by avoiding unnecessary content refreshes when resizing, scrolling Feb 3, 2025
@coveralls
Copy link

Coverage Status

coverage: 62.658% (+0.04%) from 62.619%
when pulling 2e35ca0 on dweymouth:efficient-gridwrap-resize
into 5ebf631 on fyne-io:develop.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimisation for the horizontal resize :)

@dweymouth dweymouth merged commit 0b5a53e into fyne-io:develop Feb 4, 2025
11 checks passed
@dweymouth dweymouth deleted the efficient-gridwrap-resize branch February 4, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants