Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make table scrolling and resizing more efficient #5496

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Make table scrolling and resizing more efficient #5496

wants to merge 2 commits into from

Conversation

dweymouth
Copy link
Contributor

Description:

Only refresh newly visible cells when scrolling and resizing the table

Progresses #5456 (for Table)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 62.632% (+0.01%) from 62.619%
when pulling 3e6b28c on dweymouth:efficient-table-size-scroll
into 5ebf631 on fyne-io:develop.

andydotxyz
andydotxyz requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, nice solution.
Just a drive-by comment as I've not managed to test the code yet - but let's unexport methods by default

widget/table.go
c.RefreshForID(onlyNewTableCellsID) // trigger a redraw
}

func (c *tableCells) RefreshForID(id TableCellID) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be left unexported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweymouth @coveralls @andydotxyz