Create temporary tables to improve performance #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create temporary tables for symbols and instructions to improve performance. There is an upfront cost to ingesting the data into a temporary table but it's relatively nominal (2s) and every query is WAY faster afterwards. Also moved pyright to a poetry dependency.
fzakaria
commented
Sep 1, 2023
| @@ -63,4 +63,10 @@ def register(connection: apsw.Connection, binaries: list[lief.Binary]): | |||
| generator.columns, generator.column_access = apsw.ext.get_column_names( | |||
| next(generator()) | |||
| ) | |||
| apsw.ext.make_virtual_module(connection, "elf_instructions", generator) | |||
| apsw.ext.make_virtual_module(connection, "raw_elf_instructions", generator) | |||
| connection.execute( | |||
There was a problem hiding this comment.
TODO: maybe make this a flag to control whether a user wants to pay the cost?
Might be worthwhile for tiny binaries.
fzakaria
commented
Sep 1, 2023
| @@ -6,6 +6,7 @@ | |||
| import apsw | |||
| import apsw.ext | |||
| import lief | |||
| from ..elf.section import section_name as elf_section_name | |||
There was a problem hiding this comment.
i don't understand how to import :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create temporary tables for symbols and instructions to improve performance.
There is an upfront cost to ingesting the data into a temporary table but it's relatively nominal (2s) and every query is WAY faster afterwards.
Also moved pyright to a poetry dependency.
TY for help and advice from @rogerbinns