Fix build error with GLM_FORCE_INTRINSICS and NEON #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
much needed ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a project using
GLM_FORCE_INTRINSICSthat builds on Apple ARM-based platforms. When attempting to update GLM, I saw some build breaks because the NEONcompute_vec_nequalimplementation was missing a template parameter on its call tocompute_vec_equal.I didn't see a test exercising
GLM_FORCE_INTRINSICS, so I addedcore_force_intrinsicsthat's currently just a copy ofcore_force_purebut with a different define. I wasn't sure what a good scope for that test would be, so I'm happy to cut it down or otherwise alter it if that's preferred (or refactor to share code between them).The test did indeed reproduce the build failure, as well as a warning promoted to an error about an unused variable. With these changes, all tests now build and pass on my M1 Mac.