Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Functional Impact Annotation Definition and Scope #34

Open
mbrush opened this issue Mar 19, 2019 · 3 comments
Open

Experimental Functional Impact Annotation Definition and Scope #34

mbrush opened this issue Mar 19, 2019 · 3 comments
Labels
VA type definition Base ticket for defining and scoping a VA type

Comments

@mbrush
Copy link
Contributor

mbrush commented Mar 19, 2019

We will initially proceed with our initial decision to split 'Predicted' from 'Experimental' Functional impact annotations - and model these as separate VA types. Our rationale was that:

  • they have very different provenances and evidence types (computational vs experimentally validated)
  • they make statements about functionality at different levels of granularity
  • there is a fairly clean separation in terms of the processes, tools, and sources for these VA types
  • there is a clear understanding in the community w.r.t. how they are different and how they can be used

The proposals/notes below are derived from the initial requirements work for this VA type here.


Definition: a statement about the impact of a variant on gene product function, as supported by experimental evidence.

Scope/Comments:

  • These statements may describe the impact in more general terms (e.g. ‘loss of function’, ‘gain of function’), but they often describe more precisely how a specific function or activity of the gene product is affected (e.g. increased enzymatic activity, decreased localization to the nucleus)
  • The key feature distinguishing these from "Predicted Functional Impact" annotations is their experimental basis (i.e. some in vitro or in vivo experiment was done to show the impact).
  • Additionally, there is typically greater specificity in defining the impact (typically indicating impact on a particular function, as opposed to simply ‘damaging’ or ‘tolerated’).
  • These distinctions are important because consumers of functional impact annotations trust and apply them differently than predicted derived annotations.
@mbrush mbrush added the VA type definition Base ticket for defining and scoping a VA type label Mar 19, 2019
@mbrush
Copy link
Contributor Author

mbrush commented Mar 19, 2019

Some examples of terms used to describe experimental impact:

More General Terms:

More Specific Terms

@mbrush
Copy link
Contributor Author

mbrush commented Apr 10, 2019

Elements to capture in a statement model: (based on notes from initial requirements work here)

  • variant - typically a precise variant instance, can be at genomic, transcript, or protein level
  • functional impact - a description of the immediate effect of the variant the function or behavior of its gene product
  • affected gene product - use in cases where a genomic-level variant is specified, and the impact applies to a particular transcript or protein isoform

The statement semantics here seem fairly simple, and map cleanly to an ACM-based model as follows:

  • subject: Variation (1..1)
  • predicate: code {has_functional_impact / has_phenotype} (1..1)
  • object: string (1..1) ## impacts too diverse here to codify, as there is no existing relevant CV - but can provide recommendations on how to form strings in the documentation. See notes below.
  • affectedFeatureQualifier: [ Transcript | Protein ]

Issues/Questions:

  • As for predicted functional impact, understanding diversity of impact terms here, and deciding how to frame/constrain their entry, is key challenge.
  • Consider the idea that these impacts can be framed as 'molecular phenotypes', such that this VA type becomes a specific kind of G2P annotation.
  • And evidence and provenance information for this VA type could be particularly rich and important to capture in detail - given broad use of this VA type as evidence for clinical interpretations, the diversity and nuance of experimental design and execution, and the history of inconsistent interpretation and application of functional data in variant interpretation efforts (e.g. CSER studies)
  • Look at what the ClinGen Functional Data Pipeline effort is doing here, and elicit requirements from them? Maybe have them present on a call - with focus on their use cases, requirements, and data
  • Consider creative ways to add structure and consistency to the descriptor for this VA type. Will be important for integration and search of this data. Values will be diverse, esp when very precise impacts are describe (e.g. decreased binding to ER membrane) . . .but there may be a way to provide a recommended value set that covers most values, and/or define a 'Molecular Phenotype' object where the impact value can be composed from more fundamental terms (e.g. an entity-attribute like pattern as used in most phenotype ontologies). Efforts like NextProt that produce experimental functional impact data may already do something like this.

@ahwagner
Copy link
Member

Relevant discussion on griffithlab/civic-docs#46 (comment). In short, this model is a subset of the functional evidence statements (EIDs) from CIViC, though it excludes the disease field (which will, going forward, always be set to "cancer"). Since there is (or more precisely, will be) no variability in the value set for that attribute, I think it is safe to model functional evidence from CIViC under the proposed Experimental Functional Impact Annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VA type definition Base ticket for defining and scoping a VA type
Projects
None yet
Development

No branches or pull requests

2 participants