Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translator to/from methods should be public #481

Open
jsstevenson opened this issue Jan 30, 2025 · 1 comment
Open

translator to/from methods should be public #481

jsstevenson opened this issue Jan 30, 2025 · 1 comment

Comments

@jsstevenson
Copy link
Contributor

I think the intention here is to direct a user to use the base translate methods rather than the format-specific ones, and use the fmt arg to get what they want. However, the benefit of going directly to the specific methods is that it does afford a bit more type checking rather than dumping everything as **kwargs. In practice, we definitely make use of those private methods directly (eg in the VCF annotator), so it might be time to just make them publicly.

@jsstevenson
Copy link
Contributor Author

If this is gonna change to a big "clean up the translator" issue: why is _Translator an ABC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant