forked from conda-incubator/conda-store-ui
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow passing
variables
via raw YAML (conda-incubator#354)
* Allow passing `variables` via raw YAML Fixes conda-incubator#350. * Replace `formatCode` with `stringify` * Use `variables` from the global state * Do not repeat `variables` twice * Get back to using `formatCode` The custom pretty-printer is there to avoid printing `[]` when no data is available, which is not very user-friendly. * Rename `variables` to `environmentVariables` * Check if text input is working in playwright tests * Fixup: serialize as `variables` * Add tests * Add more tests * Fixup: serialize as `variables` on create * Update tests * Fixup: serialize as `variables` on edit * Fixup: serialize as `variables` on edit * Rename back to `variables` in `CondaSpecification` * Fixup: rename back to `variables` to avoid serialization bugs * Fix the test * Revert "Check if text input is working in playwright tests" This reverts commit 5f08435. * Update tests * Create a new test * Check siblings * Add waitFor * Run linter * Save variables on toggle on create env * Save variables on toggle on edit env * Revert all test changes * Remove redundant dispatch * Fix a broken test
- Loading branch information
Showing
10 changed files
with
161 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/features/environmentVariables/environmentVariablesSlice.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { createSlice } from "@reduxjs/toolkit"; | ||
import { environmentDetailsApiSlice } from "../environmentDetails"; | ||
|
||
export interface IEnvironmentVariablesState { | ||
environmentVariables: Record<string, string>; | ||
} | ||
|
||
const initialState: IEnvironmentVariablesState = { environmentVariables: {} }; | ||
|
||
export const environmentVariablesSlice = createSlice({ | ||
name: "environmentVariables", | ||
initialState, | ||
reducers: { | ||
updateEnvironmentVariables: (state, action) => { | ||
const environmentVariables = action.payload; | ||
state.environmentVariables = environmentVariables; | ||
} | ||
}, | ||
extraReducers: builder => { | ||
builder.addMatcher( | ||
environmentDetailsApiSlice.endpoints.getBuild.matchFulfilled, | ||
( | ||
state, | ||
{ | ||
payload: { | ||
data: { | ||
specification: { | ||
spec: { variables: environmentVariables } | ||
} | ||
} | ||
} | ||
} | ||
) => { | ||
state.environmentVariables = environmentVariables; | ||
} | ||
); | ||
} | ||
}); | ||
|
||
export const { updateEnvironmentVariables } = environmentVariablesSlice.actions; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from "./environmentVariablesSlice"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.