WIP - PTT PFT #11
WIP - PTT PFT #11
Conversation
|
👋 I'm here to help you review your pull request. When you're ready for me to perform a review, you can comment anywhere on this pull request with this command: As a reminder, here are some helpful tips on how we can collaborate together:
|
| @@ -449,6 +449,7 @@ cdef class PTTDirectionGetter(ProbabilisticDirectionGetter): | |||
| for i in range(1, len_streamlines): | |||
| if self.propagate(): | |||
| # the propagation failed | |||
| stream_status = ENDPOINT | |||
There was a problem hiding this comment.
I don't think this change is correct. The status shouldn't be changed. When propagates fails, the status is TRACKPOINT and should remains like this.
There was a problem hiding this comment.
This is fix below to deal with the trackpoint status
|
|
||
| i += i_sub-1 | ||
| copy_point(&streamline[i-1,0], point) | ||
| # stream_status[0] = sc.check_point_c(point) | ||
|
|
||
| current_wm_pve = 1.0 - sc.get_include(point) - sc.get_exclude(point) |
There was a problem hiding this comment.
this block needs to check all generated points, no only le last point.
# update max_wm_pve
for j in range(i_sub):
pve_j = (1.0 - sc.get_include_c(&sub_streamline[j, 0]) - sc.get_exclude_c(&sub_streamline[j, 0]))
if pve_j > max_wm_pve:
max_wm_pve = pve_j
dipy/tracking/localtrack.pyx
Outdated
|
|
||
| current_wm_pve = 1.0 - sc.get_include(point) - sc.get_exclude(point) | ||
| if current_wm_pve > max_wm_pve: | ||
| max_wm_pve = current_wm_pve | ||
|
|
||
| if stream_status[0] == TRACKPOINT: | ||
| # The tracking continues normally | ||
| # print("Se sale con status TRACKPOINT", i_sub) |
There was a problem hiding this comment.
line 272-275 can be removed, and line 281 should become
elif stream_status[0] == INVALIDPOINT or stream_status[0] == TRACKPOINT:
If the generate_streamline(.) reaches an invalid point or stops in the WM (i.e. TRACKPOINT), pft should be used.
line 276:
if (stream_status[0] == ENDPOINT
BF - streamstatus
No description provided.